Waraxe IT Security Portal
Login or Register
January 15, 2026
Menu
Home
Logout
Discussions
Forums
Members List
IRC chat
Tools
Base64 coder
MD5 hash
CRC32 checksum
ROT13 coder
SHA-1 hash
URL-decoder
Sql Char Encoder
Affiliates
y3dips ITsec
Md5 Cracker
User Manuals
AlbumNow
Content
Content
Sections
FAQ
Top
Info
Feedback
Recommend Us
Search
Journal
Your Account
User Info
Welcome, Anonymous
Nickname
Password
(Register)

Membership:
Latest: MichaelSnaRe
New Today: 0
New Yesterday: 0
Overall: 9144

People Online:
Visitors: 209
Members: 0
Total: 209
Full disclosure
Defense in depth -- the Microsoft way (part 95): the (shared)"Start Menu" is dispensable
Re: Multiple Security Misconfigurations and CustomerEnumeration Exposure in Convercent Whistleblowing Platform(EQS Group)
RIOT OS 2026.01-devel-317 Stack-Based Buffer Overflow in RIOT ethos Serial Frame Parser
RIOT OS 2026.01-devel-317 Stack-Based Buffer Overflow in tapslip6 Utility via Unbounded Device Path Construction
TinyOS 2.1.2 Stack-Based Buffer Overflow in mcp2200gpio
TinyOS 2.1.2 printfUART Global Buffer Overflow via UnboundedFormat Expansion
KL-001-2026-01: yintibao Fun Print Mobile Unauthorized Access via Context Hijacking
Multiple Security Misconfigurations and Customer Enumeration Exposure in Convercent Whistleblowing Platform (EQS Group)
Panda3d v1.10.16 Uncontrolled Format String in Panda3D egg-mkfont Allows Stack Memory Disclosure
Panda3d v1.10.16 egg-mkfont Stack Buffer Overflow
Panda3d v1.10.16 deploy-stub Unbounded Stack Allocation Leading to Uninitialized Memory
MongoDB v8.3.0 Integer Underflow in LMDB mdb_load
Bioformats v8.3.0 Untrusted Deserialization of Bio-Formats Memoizer Cache Files
Bioformats v8.3.0 Improper Restriction of XML External Entity Reference in Bio-Formats Leica Microsystems XML Parser
MongoDB v8.3.0 Heap Buffer Underflow in OpenLDAP LMDB mdb_load
Log in Register Forum FAQ Memberlist Search
IT Security and Insecurity Portal

www.waraxe.us Forum Index -> Sql injection -> PHP code to prevent
Post new topicReply to topic View previous topic :: View next topic
PHP code to prevent
PostPosted: Wed Jan 03, 2007 11:09 pm Reply with quote
Lord_Vader
Regular user
Regular user
Joined: Jan 04, 2007
Posts: 5
Location: Netherlands




We all know this code is vunarable for SQL injection:
Code:

$user=$_POST['username'];
$pass=$_POST['password'];
$result=mysql_query("SELECT * FROM admin_users WHERE user='$user' AND pass='$pass'");
$row=mysql_fetch_row($result);
if($row==0)
{
die("Wrong login!");
}


But what should I use then?
I'm stuck here.

Thanks in advance
View user's profile Send private message Visit poster's website
PostPosted: Thu Jan 04, 2007 12:01 pm Reply with quote
waraxe
Site admin
Site admin
Joined: May 11, 2004
Posts: 2407
Location: Estonia, Tartu




This code by himself does not contain sql injection, because of the single quotes, surrounding input variables. Now, most of the real world php-enabled webservers are configured with "magic_quotes=on", so sql injection attempts will fail.
IF and only IF you encounter webserver with "magic_quotes=off", ten you can have sql injection case here, if there is no additional php code, responsible for input data sanitize.
In the last case you can try this username:

'OR 1=1 LIMIT 1/*

and let the password be whatever you want.
Then beause of the sql injection you will be loged on as first admin in table.
By the way, php pcode wants POST method, so you need manually crafted html file for exploiting.

P.S. I figured it out, that you asked question from webmaster's point of view, not from attacker's. So you want better code?
First of all, don't use plaintext passwords in database, better use salted md5 hashes.
View user's profile Send private message Send e-mail Visit poster's website
PostPosted: Thu Jan 04, 2007 12:31 pm Reply with quote
Chb
Valuable expert
Valuable expert
Joined: Jul 23, 2005
Posts: 206
Location: Germany




Secondary: Use mysql_real_escape_string() and maybe also addslashes() for escaping user input to prevent code.

_________________
www.der-chb.de
View user's profile Send private message Visit poster's website ICQ Number
PostPosted: Mon Jan 08, 2007 12:54 am Reply with quote
Lord_Vader
Regular user
Regular user
Joined: Jan 04, 2007
Posts: 5
Location: Netherlands




Ok, I get it. Thanks for the replies.
I use mysql_real_escape_string() for security.
@waraxe: Yes, I use MD5, but I only posted part of my code
View user's profile Send private message Visit poster's website
PHP code to prevent
www.waraxe.us Forum Index -> Sql injection
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
All times are GMT
Page 1 of 1

Post new topicReply to topic


Powered by phpBB © 2001-2008 phpBB Group



PCWizardHub - Helping you fix, build, and optimize your PC life
All logos and trademarks in this site are property of their respective owner. The comments and posts are property of their posters, all the rest (c) 2004-2024 Janek Vind "waraxe"
Page Generation: 0.043 Seconds