Waraxe IT Security Portal
Login or Register
October 12, 2024
Menu
Home
Logout
Discussions
Forums
Members List
IRC chat
Tools
Base64 coder
MD5 hash
CRC32 checksum
ROT13 coder
SHA-1 hash
URL-decoder
Sql Char Encoder
Affiliates
y3dips ITsec
Md5 Cracker
User Manuals
AlbumNow
Content
Content
Sections
FAQ
Top
Info
Feedback
Recommend Us
Search
Journal
Your Account
User Info
Welcome, Anonymous
Nickname
Password
(Register)

Membership:
Latest: MichaelSnaRe
New Today: 0
New Yesterday: 0
Overall: 9144

People Online:
Visitors: 83
Members: 0
Total: 83
Full disclosure
SEC Consult SA-20241009-0 :: Local Privilege Escalation via MSI installer in Palo Alto Networks GlobalProtect (CVE-2024-9473)
APPLE-SA-10-03-2024-1 iOS 18.0.1 and iPadOS 18.0.1
Some SIM / USIM card security (and ecosystem) info
SEC Consult SA-20240930-0 :: Local Privilege Escalation via MSI Installer in Nitro PDF Pro (CVE-2024-35288)
Backdoor.Win32.Benju.a / Unauthenticated Remote CommandExecution
Backdoor.Win32.Prorat.jz / Remote Stack Buffer Overflow (SEH)
Backdoor.Win32.Amatu.a / Remote Arbitrary File Write (RCE)
Backdoor.Win32.Agent.pw / Remote Stack Buffer Overflow (SEH)
Backdoor.Win32.Boiling / Remote Command Execution
Defense in depth -- the Microsoft way (part 88): a SINGLEcommand line shows about 20, 000 instances of CWE-73
SEC Consult SA-20240925-0 :: Uninstall Password Bypass in BlackBerry CylanceOPTICS Windows Installer Package (CVE-2024-35214)
Apple iOS 17.2.1 - Screen Time Passcode Retrieval (MitigationBypass)
CyberDanube Security Research 20240919-0 | Multiple Vulnerabilities in Netman204
Submit Exploit CVE-2024-42831
Stored XSS in "Edit Profile" - htmlyv2.9.9
Log in Register Forum FAQ Memberlist Search
IT Security and Insecurity Portal

www.waraxe.us Forum Index -> How to fix -> How to fix new discovered flaws in Reviews module
Post new topicReply to topic View previous topic :: View next topic
How to fix new discovered flaws in Reviews module
PostPosted: Tue Jun 08, 2004 2:01 pm Reply with quote
waraxe
Site admin
Site admin
Joined: May 11, 2004
Posts: 2407
Location: Estonia, Tartu




Here is the original advisory:

http://bichosoft.webcindario.com/advisory-05.txt
http://groups.google.com/groups?selm=ca3hg2%24216i%241%40FreeBSD.csie.NCTU.edu.tw&output=gplain

There are 2 problems in Reviews module index.php , one of them leading to full path disclosure (in Windows servers only) and secons has XSS capabilities. Here is the fix:

Fist, open index.php fom "/modules/reviews" and locate this code fragment (~line 524):

Code:

function showcontent($id, $page) {
global $admin, $uimages, $prefix, $db, $module_name;
$id = intval($id);
$page = intval($page);
include ('header.php');
OpenTable();
if (($page == 1) OR ($page == "")) {
$db->sql_query("UPDATE ".$prefix."_reviews SET hits=hits+1 WHERE id='$id'");
}
$result = $db->sql_query("SELECT * FROM ".$prefix."_reviews WHERE id='$id'");
$myrow = $db->sql_fetchrow($result);
$id = intval($myrow['id']);
$date = $myrow['date'];


Now add additional sanitize code, so final result will be as:

Code:

function showcontent($id, $page) {
global $admin, $uimages, $prefix, $db, $module_name;
$id = intval($id);
$page = intval($page);
include ('header.php');
OpenTable();
if (($page == 1) OR ($page == "")) {
$db->sql_query("UPDATE ".$prefix."_reviews SET hits=hits+1 WHERE id='$id'");
}
$result = $db->sql_query("SELECT * FROM ".$prefix."_reviews WHERE id='$id'");
$myrow = $db->sql_fetchrow($result);
$id = intval($myrow['id']);

//-- Fix by waraxe http://www.waraxe.us --------

if(empty($id)) die('Wrong ID!');

//------------------------------------------------------

$date = $myrow['date'];


Next we will patch the xss hole. So find this code fragment from "/modules/Revies/index.php" (~line 418):

Code:

function postcomment($id, $title) {
global $user, $cookie, $AllowableHTML, $anonymous, $module_name;
include("header.php");
cookiedecode($user);
OpenTable();


And add additional security code, so finally you will have:

Code:

function postcomment($id, $title) {
global $user, $cookie, $AllowableHTML, $anonymous, $module_name;
include("header.php");
cookiedecode($user);

//-- xss prevention by waraxe, refference: http://www.waraxe.us/? modname=sa&id=002
$title = htmlentities(urldecode($title));
//--------------------------------------------------------------------------

if(empty($id)||!(is_numeric($id)))
{
die('Wrong ID!');
}
else
{
$id = intval($id);
}

OpenTable();


Congratulations, you have now one step closer to flawless nuke Wink
View user's profile Send private message Send e-mail Visit poster's website
PostPosted: Wed Jun 09, 2004 1:42 pm Reply with quote
SteX
Advanced user
Advanced user
Joined: May 18, 2004
Posts: 181
Location: Serbia




Quote:
one step closer

2 many steps to flawless nuke Rolling Eyes

_________________

We would change the world, but God won't give us the sourcecode...
....Watch the master. Follow the master. Be the master....
-------------------------------------------------------
View user's profile Send private message
PostPosted: Thu Jun 10, 2004 4:45 pm Reply with quote
waraxe
Site admin
Site admin
Joined: May 11, 2004
Posts: 2407
Location: Estonia, Tartu




More bugfixes in Reviews module will be published soon, stay tuned! Very Happy
View user's profile Send private message Send e-mail Visit poster's website
How to fix new discovered flaws in Reviews module
www.waraxe.us Forum Index -> How to fix
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
All times are GMT
Page 1 of 1

Post new topicReply to topic


Powered by phpBB © 2001-2008 phpBB Group



Space Raider game for Android, free download - Space Raider gameplay video - Zone Raider mobile games
All logos and trademarks in this site are property of their respective owner. The comments and posts are property of their posters, all the rest (c) 2004-2024 Janek Vind "waraxe"
Page Generation: 0.044 Seconds